Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/mq_broker: Fix crash in hashing function #2598

Merged
merged 1 commit into from
Dec 13, 2017
Merged

r/mq_broker: Fix crash in hashing function #2598

merged 1 commit into from
Dec 13, 2017

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Dec 8, 2017 •
edited
Loading

This crash may occur when user is in "pending" state (typically happens after creation when broker reaches CREATION_FAILED state). There's practically no data about the user as it's pending.

Example of response

(we expect the consoleAccess and groups to be in the root level when user has no pending changes)

{
  "brokerId": "b-1e789f39-269d-4689-9f04-8dbe47181632",
  "username": "Test",
  "pending": {
    "pendingChange": "CREATE",
    "consoleAccess": false,
    "groups": []
  }
}

Related test failure

=== RUN   TestAccAwsMqBroker_allFields

------- Stderr: -------
panic: interface conversion: interface {} is nil, not bool

goroutine 4280 [running]:
github.com/terraform-providers/terraform-provider-aws/aws.resourceAwsMqUserHash(0x2601760, 0xc42068bb60, 0xc4204e1c98)
    /opt/teamcity-agent/work/74d56ebce219706d/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_mq_broker.go:389 +0x5a1
github.com/terraform-providers/terraform-provider-aws/vendor/github.com/hashicorp/terraform/helper/schema.(*Set).hash(0xc4204e1c80, 0x2601760, 0xc42068bb60, 0x7fd44ab649b8, 0x0)
    /opt/teamcity-agent/work/74d56ebce219706d/src/github.com/terraform-providers/terraform-provider-aws/vendor/github.com/hashicorp/terraform/helper/schema/set.go:205 +0x3d
github.com/terraform-providers/terraform-provider-aws/vendor/github.com/hashicorp/terraform/helper/schema.(*Set).add(0xc4204e1c80, 0x2601760, 0xc42068bb60, 0x2875700, 0xc42059af01, 0xc4204e1c80)
    /opt/teamcity-agent/work/74d56ebce219706d/src/github.com/terraform-providers/terraform-provider-aws/vendor/github.com/hashicorp/terraform/helper/schema/set.go:192 +0x72
github.com/terraform-providers/terraform-provider-aws/vendor/github.com/hashicorp/terraform/helper/schema.(*Set).Add(0xc4204e1c80, 0x2601760, 0xc42068bb60)
    /opt/teamcity-agent/work/74d56ebce219706d/src/github.com/terraform-providers/terraform-provider-aws/vendor/github.com/hashicorp/terraform/helper/schema/set.go:69 +0x44
github.com/terraform-providers/terraform-provider-aws/vendor/github.com/hashicorp/terraform/helper/schema.NewSet(0x2d002a8, 0xc4204e1c60, 0x2, 0x2, 0x2)
    /opt/teamcity-agent/work/74d56ebce219706d/src/github.com/terraform-providers/terraform-provider-aws/vendor/github.com/hashicorp/terraform/helper/schema/set.go:56 +0x7a
github.com/terraform-providers/terraform-provider-aws/aws.flattenMqUsers(0xc42059a700, 0x2, 0x2, 0xc4204e1be0, 0x2, 0x2, 0x0)
    /opt/teamcity-agent/work/74d56ebce219706d/src/github.com/terraform-providers/terraform-provider-aws/aws/structure.go:2981 +0x745
github.com/terraform-providers/terraform-provider-aws/aws.resourceAwsMqBrokerRead(0xc4201f5ab0, 0x27683e0, 0xc42062a000, 0x0, 0x4870780)
    /opt/teamcity-agent/work/74d56ebce219706d/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_mq_broker.go:305 +0xf64
github.com/terraform-providers/terraform-provider-aws/vendor/github.com/hashicorp/terraform/helper/schema.(*Resource).Refresh(0xc4203c3180, 0xc42099bd10, 0x27683e0, 0xc42062a000, 0xc420460578, 0xc42060b801, 0xc4205aaab0)
    /opt/teamcity-agent/work/74d56ebce219706d/src/github.com/terraform-providers/terraform-provider-aws/vendor/github.com/hashicorp/terraform/helper/schema/resource.go:355 +0x199
github.com/terraform-providers/terraform-provider-aws/vendor/github.com/hashicorp/terraform/helper/schema.(*Provider).Refresh(0xc420447c70, 0xc4206f4aa0, 0xc42099bd10, 0x0, 0xbe82c6704afd620b, 0x18bc3b330d1)
    /opt/teamcity-agent/work/74d56ebce219706d/src/github.com/terraform-providers/terraform-provider-aws/vendor/github.com/hashicorp/terraform/helper/schema/provider.go:308 +0x9a
github.com/terraform-providers/terraform-provider-aws/vendor/github.com/hashicorp/terraform/terraform.(*EvalRefresh).Eval(0xc420673620, 0x47dafc0, 0xc420792270, 0x2, 0x2, 0x2b2a28f, 0x4)
    /opt/teamcity-agent/work/74d56ebce219706d/src/github.com/terraform-providers/terraform-provider-aws/vendor/github.com/hashicorp/terraform/terraform/eval_refresh.go:37 +0x149
github.com/terraform-providers/terraform-provider-aws/vendor/github.com/hashicorp/terraform/terraform.EvalRaw(0x47cbb20, 0xc420673620, 0x47dafc0, 0xc420792270, 0x29a76c0, 0xc42099bd10, 0x0, 0x0)
    /opt/teamcity-agent/work/74d56ebce219706d/src/github.com/terraform-providers/terraform-provider-aws/vendor/github.com/hashicorp/terraform/terraform/eval.go:53 +0x173
github.com/terraform-providers/terraform-provider-aws/vendor/github.com/hashicorp/terraform/terraform.(*EvalSequence).Eval(0xc420673640, 0x47dafc0, 0xc420792270, 0x2, 0x2, 0x2b2a28f, 0x4)
    /opt/teamcity-agent/work/74d56ebce219706d/src/github.com/terraform-providers/terraform-provider-aws/vendor/github.com/hashicorp/terraform/terraform/eval_sequence.go:14 +0x7e
github.com/terraform-providers/terraform-provider-aws/vendor/github.com/hashicorp/terraform/terraform.EvalRaw(0x47cbbe0, 0xc420673640, 0x47dafc0, 0xc420792270, 0x25c22a0, 0x47dc005, 0x239a960, 0xc4204eb140)
    /opt/teamcity-agent/work/74d56ebce219706d/src/github.com/terraform-providers/terraform-provider-aws/vendor/github.com/hashicorp/terraform/terraform/eval.go:53 +0x173
github.com/terraform-providers/terraform-provider-aws/vendor/github.com/hashicorp/terraform/terraform.Eval(0x47cbbe0, 0xc420673640, 0x47dafc0, 0xc420792270, 0xc420673640, 0x47cbbe0, 0xc420673640, 0xc4206d7bb0)
    /opt/teamcity-agent/work/74d56ebce219706d/src/github.com/terraform-providers/terraform-provider-aws/vendor/github.com/hashicorp/terraform/terraform/eval.go:34 +0x4d
github.com/terraform-providers/terraform-provider-aws/vendor/github.com/hashicorp/terraform/terraform.(*Graph).walk.func1(0x2a97280, 0xc4209cac00, 0x0, 0x0)
    /opt/teamcity-agent/work/74d56ebce219706d/src/github.com/terraform-providers/terraform-provider-aws/vendor/github.com/hashicorp/terraform/terraform/graph.go:126 +0xd0d
github.com/terraform-providers/terraform-provider-aws/vendor/github.com/hashicorp/terraform/dag.(*Walker).walkVertex(0xc4201c9960, 0x2a97280, 0xc4209cac00, 0xc4206516c0)
    /opt/teamcity-agent/work/74d56ebce219706d/src/github.com/terraform-providers/terraform-provider-aws/vendor/github.com/hashicorp/terraform/dag/walk.go:387 +0x3c1
created by github.com/terraform-providers/terraform-provider-aws/vendor/github.com/hashicorp/terraform/dag.(*Walker).Update
    /opt/teamcity-agent/work/74d56ebce219706d/src/github.com/terraform-providers/terraform-provider-aws/vendor/github.com/hashicorp/terraform/dag/walk.go:310 +0x1364

@radeksimko radeksimko added bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. labels Dec 8, 2017
tombuildsstuff
tombuildsstuff approved these changes Dec 13, 2017
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@radeksimko radeksimko merged commit 20fd5ce into master Dec 13, 2017
@radeksimko radeksimko deleted the b-mq-broker-hash branch December 13, 2017 13:27
@ghost
Copy link

ghost commented Apr 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radeksimko @tombuildsstuff